Steve
Will try to answer a couple.
What can I expect to pay for a reliable bike?
Due to high import fees you will pay more than in US, Would be cheaper to buy in US and have shipped to your location. Non resident buying vehicles can be a major problem and may cause problems at border crossings.
Does it have to be street legal or is a dirt bike OK?
It will need to be street legal.
How hard is it to buy a bike in SA? I'm an American citizen.
Can be major problem, see other posts
Can I sell it after my trip ends?
Not legal generally unless you sell to someone from country where it is registered and they transfer title there.
Cities/spots you think are very fun or must see?
Unless you have a couple of years you will never see it all but check the travel stories for ideas on what to see.
How should I carry my cash? (keep from being stolen)
Use credit cards and cash machines (found most everywhere), debit cards better because of limit to what could be stolen. What cash you take should be in mulitiple places, some hid on bike, money belt, in boot, etc. Always carry two wallets, one a "muggers wallet" with only a small amount in it and some old credit cards.
You need to spend some time going through posts here to get an idea of what to expect and how to make it work.
Bob